Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474984 --- Comment #12 from Jan ONDREJ <ondrejj@xxxxxxxxxx> 2008-12-13 01:59:52 EDT --- (In reply to comment #11) > Please remove one of the two occurrences of autoconf OK, removed. > and also the "Requires: > gd", rpmbuild will automatically require libgd.so.2()(64bit) OK. > You could also remove "BR: libpng-devel", gd-devel brings it in automatically. OK. > What do you feel about including the phphtdocs directory as docs? I'd say it > becomes useful in the database context. I suggest using: > %{?!_without_pgsql:%doc phphtdocs } > I have just tested, the package builds fine and php is not brought in as a > Requires, leaving to the admin the decision to use these scripts or not. Added. SRPM: http://www.salstar.sk/pub/fedora/SRPMS/10/bandwidthd-2.0.1-8.fc10.src.rpm %changelog * Sat Dec 13 2008 Jan ONDREJ (SAL) <ondrejj(at)salstar.sk> - 2.0.1-8 - removed dependency on gd - removed one line of autoconf - removed dependency on libpng-devel - phphtdocs added for pgsql build, execute bit for gif and sh removed -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review