Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225798 Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-12-12 11:31:39 EDT --- (In reply to comment #5) > (In reply to comment #4) > > The macro entries with single % expand into the files.list . This is equivalent > > to putting hard-coded paths into %files . I think those macro entries need > > double-% too. > > Technically they needn't be, as it doesn't really matter if they're expanded > while files.list is built or while it is evaluated by rpmbuild. I've changed it > to be more consistent, though. > You're right. I thought more about it. It shouldn't matter. > > * Parallel make must be supported whenever possible (If it is not supported, > > this should be noted in the SPEC file as a comment.). Sorry that I missed this > > in my initial review. Enabling the parallel make didn't cause a problem with my > > dual core. It certainly speeds things up. > > I've changed that and started building gimp-2.4.2-3.fc11 with these changes. I checked koji. It looks all good. ------------------------------------------- The package "gimp-help" is APPROVED by oget ------------------------------------------- -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review