Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=226568 Till Maas <opensource@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |opensource@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |opensource@xxxxxxxxx Flag| |fedora-review? --- Comment #3 from Till Maas <opensource@xxxxxxxxx> 2008-12-11 12:40:21 EDT --- (In reply to comment #2) > Can it be possible to ask "fedora-cvs?" without formal review? This is possible for packages that are under "Merge Review", because they are already included in Fedora. About the package: - Why is xsltproc required via a path instead of using libxslt? If libxslt cannot be used, please explain with a comment in the spec. - It is recommended not to use %makeinstall, is there a reason to use it? It builds fine here with: make install DESTDIR=$RPM_BUILD_ROOT - parallel make is not used: make %{?_smp_mflags} - Is the touch command still needed? If it is, please explain why in the spec file or fix it upstream: touch doc/xmlto.xml doc/xmlif.xml - License Tag should be GPLv2+ according to the header in xmlto.in - License is in the tarball, but not in %doc: COPYING - There is more documentation missing: README ChangeLog AUTHORS NEWS, maybe FAQ if it is planned to add more to this file in the future - Btw. fedorahosted provides a way to distribute releases without using the scm, but I do not know how to upload something there: https://fedorahosted.org/releases/ If you want and permissions are open in cvs, I can fix at least the issues that do not need a comment from you. I will then perform a full review later. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review