[Bug 226420] Merge Review: slang

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=226420


Jon Ciesla <limb@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |limb@xxxxxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |limb@xxxxxxxxxxxx
               Flag|fedora-review+              |fedora-review?




--- Comment #3 from Jon Ciesla <limb@xxxxxxxxxxxx>  2008-12-11 12:02:26 EDT ---
On current version:
rpmlint on SRPM is clean.

rpmlint on RPMS:

slang.i386: W: file-not-utf8 /usr/share/doc/slang-2.1.4/changes.txt
The character encoding of this file is not UTF-8.  Consider converting it in
the specfile's %prep section for example using iconv(1).

Easily fixable.

slang-static.i386: W: no-documentation
The package contains no documentation (README, doc, etc). You have to include
documentation files.

Fix if static-only docs exist.

Source tag should be Source0.

Comment in spec on patch upstream status.

Otherwise, looks good on full review, no other blockers.

Also noticed that this review had been flagged + but never assigned or closed.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]