Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=225798 --- Comment #3 from Nils Philippsen <nphilipp@xxxxxxxxxx> 2008-12-11 08:29:35 EDT --- Sorry for the late reply. I've fixed the following in CVS, gimp-2.4.2-2 is building with these changes for Rawhide right now. (In reply to comment #1) > I reviewed this package. The following issues need to be addressed for > compilance with the guidelines: > > * The files AUTHORS, ChangeLog, COPYING, HACKING, NEWS, README, TERMINOLOGY > need to be listed under %doc These files get shipped except HACKING which is documentation about how to change the documentation for which you need the source anyway. > * The package owns > %dir %{_datadir}/gimp > %dir %{_datadir}/gimp/%{gimpsubver} > which are also owned by gimp. Note that the package Requires: gimp. The above > ownerships need to be dropped. Not owned anymore. > * %defattr(-,root,root,-) is preferred. Fixed. > * BuildRequires: libxml2 > is not required since > BuildRequires: libxslt > will pull that up > > * Similarly > BuildRequires: docbook-style-xsl > is not required. It will be pulled up by other dependencies. Am I wrong? The configure script of gimp-help checks directly for e.g. xmllint (included in libxml2) and .../xhtml/docbook.xsl which is included in docbook-style-xsl. I.e. both packages are required directly, therefore I keep listing them as build requirements. It doesn't matter that they in turn are required by other build requirements, I don't want to rely on that this fact doesn't change in the future. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review