Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=475427 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #8 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-12-10 23:01:27 EDT --- Ok. Just now got link in SPEC working. Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=991954 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 9e510b1106b8dac95f1f09ed1edb48ea Catalyst-Controller-HTML-FormFu-0.03007.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=6, Tests=38, 8 wallclock secs ( 0.04 usr 0.01 sys + 7.08 cusr 0.47 csys = 7.60 CPU) + Package perl-Catalyst-Controller-HTML-FormFu-0.03007-2.fc11 => Provides: perl(Catalyst::Controller::HTML::FormFu) = 0.03007 perl(Catalyst::Controller::HTML::FormFu::Action::Form) perl(Catalyst::Controller::HTML::FormFu::Action::FormConfig) perl(Catalyst::Controller::HTML::FormFu::Action::FormMethod) perl(Catalyst::Controller::HTML::FormFu::Action::MultiForm) perl(Catalyst::Controller::HTML::FormFu::Action::MultiFormConfig) perl(Catalyst::Controller::HTML::FormFu::Action::MultiFormMethod) perl(Catalyst::Helper::HTML::FormFu) Requires: perl(Carp) perl(Config::Any) perl(File::Spec) perl(HTML::FormFu) perl(HTML::FormFu::Deploy) perl(Moose) perl(NEXT) perl(Regexp::Assemble) perl(Scalar::Util) perl(base) perl(strict) perl(warnings) + Not a GUI application APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review