Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459979 Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rpm@xxxxxxxxxxxxxx --- Comment #32 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2008-12-10 17:17:22 EDT --- (In reply to comment #14) > I have built mlt Fedora 8 x86_64 with --disable-qimage --disable-mmx and it > worked also for rawhide.(0) But in this last case, i also need to disable see > in %prep section: > ---------- > #disable sse unless x86_64 > %ifnarch x86_64 > sed -i.checksse -e 's|ifndef __DARWIN__|ifdef __DARWIN__|' > src/modules/motion_est/filter_motion_est.c > #Note that this conditional is wrong > %endif SSE detection should be moved to ./configure and the code containing SSE instructions should be wrapped in #ifdef HAVE_SSE ... #endif. Please ask upstream to do that. > -------------- > I haven't checked that, but if mmx is used on ppc, then is will certainly > fails. > What i expect is mmx should be disabled in all cases unless i686: > %configure \ > ... > %ifnarch i686 > --disable-mmx \ > %endif > So anyone that want to rebuild mlt with theses options can do so with using > --target=i686 for the package. Actually, there are i686 class CPUs without MMX, for example Pentium Pro and there are i586 class CPUs with MMX (Pentium MMX, AMD K6 and K6-2/3). I'd suggest a --with mmx conditional instead. You cannot rely on --target here. Of course, it'd be best handled upstream in a fashion similar to what I've suggested for SSE above. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review