Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469931 --- Comment #4 from Andy Cress <arcress@xxxxxxxxxxxxxxxxxxxxx> 2008-12-10 15:04:34 EDT --- Dan, Thanks for the input. I've started on these items, and have committed the changes so far into the project svn. (http://ipmiutil.svn.sourceforge.net/viewvc/ipmiutil/trunk/doc/ipmiutil.spec?view=markup) - the Source tag has wrong format A: fixed in the ipmiutil.spec in svn - "%ifarch x86_pentium3 x86_pentium4" is useless on Fedora A: yes, inert for Fedora, but required for the MontaVista distro - the %ifarch to %define LibDir - use only %{_libdir} in the spec A: fixed in ipmiutil.spec - do not use absolute paths, use macros %{_{bin,sbin,lib,...}dir} A: changed in ipmiutil.spec - do not check whether %{buildroot} == "/" in %install and %clean A: fixed in ipmiutil.spec - do not gzip man pages, it is done automagically A: does this mean that the installed files should be *.8? What process does this (at rpm install time, perhaps)? - drop the %pre and %post scripts almost completely, rely on the content that Fedora provides (we have net-snmp, specific location for MIBs, ...), they should contain handling of the install shared library (call ldconfig) and take care of initscript A: significant changes, and removing some stuff. How should I detect the MIB directory, if present? - use only the new names for utils (i_*) to prevent conflicts with other packages A: I removed the symlinks for commands, there are back-compatibility issues here, this may need further investigation. The rpmlint output with the updated spec file: # rpmlint ipmiutil-2.3.2-1.i386.rpm E: ipmiutil arch-dependent-file-in-usr-share /usr/share/ipmiutil/ipmi_port E: ipmiutil arch-dependent-file-in-usr-share /usr/share/ipmiutil/events W: ipmiutil dangerous-command-in-%post ln W: ipmiutil dangerous-command-in-%postun rm # So where should extra ipmiutil-specific binaries go? They do not need to be in the PATH, IMO. I tried several locations, but rpmlint wasn't happy with my choices. The last warning seems frivilous to me, it seems removing extra stuff should be allowed in %postun. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review