Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473184 --- Comment #3 from Jim Radford <radford@xxxxxxxxxxxxx> 2008-12-08 12:25:53 EDT --- (In reply to comment #1) > Just some comments on your spec file Thanks. > - Spec file name should be clamz.spec Why? Then I can't keep all the previous links valid. FWIW, I've done this before without complaint. > - License should be GPLv3+. The header in the source says 'or (at your option) > any later version.' Done. > - 'BuildRequires: desktop-file-utils' is missing and you need to install the > .desktop file Done. > - Add README to %doc Hmm, already there; I'm going to guess you meant COPYING. > - Remove '.fc10' from your changelog entry Done. > - Don't mix $RPM_BUILD_ROOT and %{buildroot} Done. Spec URL: http://blackbean.org/review/clamz.spec SRPM URL: http://blackbean.org/review/clamz-0.2-4.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review