Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473972 --- Comment #4 from Jerome Soyer <saispo@xxxxxxxxx> 2008-12-08 10:33:04 EDT --- So first round of issues found during the review - wrong Group tags are used - check /usr/share/doc/rpm-*/GROUPS for valid group names, I suggest to use System Environment/Daemons (nufw, nuauth) , System Environment/Libraries (client library, pam), Applications/Internet (utils), Development/Libraries (for -devel), Development/Languages (for the python bindings) -> *FIXED* - drop the %{epoch} from the Provides/Requires/... as it is not defined/used -> *FIXED* - preserve timestamps on manually installed files - use "cp -p" or "install -p" -> *FIXED* - license is GPLv2 only, there is no "or any later version" clause in the sources -> *FIXED* - license text included in the source archive, but not included in any package as %doc -> *FIXED* - %{_sysconfdir}/nufw/ is owned by multiple packages (nufw, nufw-utils, nuauth), only one should really own it, other packages get it through the dependencies -> it depends... you may have nuauth and nufw on different server, i think multiple packages need %{_sysconfdir}/nufw/ - wrong initscript scriplets and package dependencies -> *FIXED* - wrong shared library scriptlets (%postun is missing) -> *FIXED* - %defattr(-,root,root,-) should be used -> *FIXED* - no need to specify --localstatedir when running %configure, it is set to /var automatically -> *FIXED* - static library and *.la archive are packaged in -devel (use %exclude in %files or "rm" in %install) -> *FIXED* - including the whole "doc" directory as %doc is not necessary, grab only the README.* and the non-manpages (acls, cache_system and debug) -> *FIXED* - the included initscript are not compliant with Fedora - LSB header is missing, service is enabled by default, ... -> *FIXED* - the auth and log modules are linked as shared libs (including the version info), so they install *.so, *.so.0 and *.so.0.0.0 - they should use "-avoid-version" in the link command -> *FIXED* - don't use /var/... in %file, use %{_localstatedir} instead -> *FIXED* - the %description for -utils talks about nutcpc, but it is stored in its own sub-package -> *FIXED* - split the Provides for nuauth to multiple lines -> *FIXED* - there is no need for the Obsoletes for nuauth -> *FIXED* - the Requires for nuauth are wrong, there are no such packages like sasl-plug-*, you want probably cyrus-sasl-* -> *FIXED* - the pam module contains rpath and the BuildRequire: chrpath is not used -> *FIXED* - the library subpackage is usually called foo-libs with headers in foo-devel, you can "Provide: libnuclient" for compatibility -> *FIXED* - why not to rename the nufw-nuauth-* packages only to nuath-* -> i prefer, it's same as Mandriva, Debian, Ubuntu, etc... module is more flexible than a monolithic package, no ? You will find all the new file at : http://saispo.free.fr/fedora/nufw.spec http://saispo.free.fr/fedora/nuauth.init http://saispo.free.fr/fedora/nufw.init I have no fedora under my hand for building a SRPM :-/ I can give you one tomorrow. Thanks in advance for your review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review