Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474768 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2008-12-08 09:18:50 EDT --- Just some comments on your spec file - '%define version 0.53' is not necessary. The number in the 'Version:' tag can be reused with %{version} - Add %{?_smp_mflags} to make in the %build section - 'BuildRoot: %{_tmppath}/%{name}_%{version}' don't match the recommandations. https://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag - Remove the *.la files. They should not be included. https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries - '%defattr(-,root,root)' should be '%defattr(-,root,root,-)' for the default directory permissions. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review