Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473972 --- Comment #2 from Dan Horák <dan@xxxxxxxx> 2008-12-07 10:29:49 EDT --- So first round of issues found during the review - wrong Group tags are used - check /usr/share/doc/rpm-*/GROUPS for valid group names, I suggest to use System Environment/Daemons (nufw, nuauth) , System Environment/Libraries (client library, pam), Applications/Internet (utils), Development/Libraries (for -devel), Development/Languages (for the python bindings) - drop the %{epoch} from the Provides/Requires/... as it is not defined/used - preserve timestamps on manually installed files - use "cp -p" or "install -p" - license is GPLv2 only, there is no "or any later version" clause in the sources - license text included in the source archive, but not included in any package as %doc - %{_sysconfdir}/nufw/ is owned by multiple packages (nufw, nufw-utils, nuauth), only one should really own it, other packages get it through the dependencies - wrong initscript scriplets and package dependencies - wrong shared library scriptlets (%postun is missing) - %defattr(-,root,root,-) should be used - no need to specify --localstatedir when running %configure, it is set to /var automatically - static library and *.la archive are packaged in -devel (use %exclude in %files or "rm" in %install) - including the whole "doc" directory as %doc is not necessary, grab only the README.* and the non-manpages (acls, cache_system and debug) - the included initscript are not compliant with Fedora - LSB header is missing, service is enabled by default, ... - the auth and log modules are linked as shared libs (including the version info), so they install *.so, *.so.0 and *.so.0.0.0 - they should use "-avoid-version" in the link command - don't use /var/... in %file, use %{_localstatedir} instead - the %description for -utils talks about nutcpc, but it is stored in its own sub-package - split the Provides for nuauth to multiple lines - there is no need for the Obsoletes for nuauth - the Requires for nuauth are wrong, there are no such packages like sasl-plug-*, you want probably cyrus-sasl-* - the pam module contains rpath and the BuildRequire: chrpath is not used - the library subpackage is usually called foo-libs with headers in foo-devel, you can "Provide: libnuclient" for compatibility - why not to rename the nufw-nuauth-* packages only to nuath-* Please read the https://fedoraproject.org/wiki/Packaging/Guidelines and linked pages for details. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review