Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474965 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-12-06 18:47:27 EDT --- It's been a while since I looked at a PHP module. rpmlint says: php-pear-Date-Holidays-USA.noarch: W: no-documentation which is not a problem. Everything else looks fine. * source files match upstream. sha256sum: 5191c518642aaa2b7a8ba52ee69b156668f5570a909cc4e0a228650b7956ff37 Date_Holidays_USA-0.1.1.tgz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint has acceptable complaints. * final provides and requires are sane: php-pear(Date_Holidays_USA) = 0.1.1 php-pear-Date-Holidays-USA = 0.1.1-1.fc11 = /bin/sh /usr/bin/pear php-pear(Date_Holidays) >= 0.18.0 php-pear(PEAR) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files. * scriptlets are OK (pear module registration). * code, not content. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review