Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474812 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-12-06 17:48:33 EDT --- rpmlint says: perl-Class-Unload.noarch: W: summary-not-capitalized unload given Class Easy to fix. perl-Class-Unload.noarch: E: description-line-too-long Unloads the given class by clearing out its symbol table and removing it from %INC. Just needs one carriage return. Those are really trivial, so I'll go ahead and approve this and you can fix them when you check in. * source files match upstream. sha256sum: 01807226cd9a6b5b1c6a02cf8408ab09e0e76e7d70f06f6d3fe3af6e41906005 Class-Unload-0.05.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK (needs capitalization). * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(Class::Unload) = 0.05 perl-Class-Unload = 0.05-1.fc11 = perl >= 0:5.005 perl(:MODULE_COMPAT_5.10.0) perl(Class::Inspector) perl(strict) perl(vars) perl(warnings) * %check is present and all tests pass: All tests successful. Files=5, Tests=21, 0 wallclock secs ( 0.01 usr 0.01 sys + 0.09 cusr 0.02 csys = 0.13 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED, just fix up Summary: and %description. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review