Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469993 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |tibbs@xxxxxxxxxxx Flag| |fedora-review+ --- Comment #5 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-12-06 16:53:55 EDT --- I had intended to get to this earlier, but better late than never. * source files match upstream. sha256sum: a47ad01575d14ecf9d953a62ead043bb715afc0eed1c34549a65f925ca180be9 MooseX-Types-URI-0.01.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(MooseX::Types::URI) = 0.01 perl-MooseX-Types-URI = 0.01-1.fc11 = perl(:MODULE_COMPAT_5.10.0) perl(Moose::Util::TypeConstraints) perl(MooseX::Types) perl(MooseX::Types::Path::Class) perl(Scalar::Util) perl(URI) perl(URI::FromHash) perl(URI::WithBase) perl(URI::data) perl(URI::file) perl(namespace::clean) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=1, Tests=51, 0 wallclock secs ( 0.01 usr 0.00 sys + 0.19 cusr 0.01 csys = 0.21 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * no scriptlets present. * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review