Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474992 --- Comment #2 from Jan ONDREJ <ondrejj@xxxxxxxxxx> 2008-12-06 13:06:58 EDT --- (In reply to comment #1) > Just some quick comments on your spec file > > - 'Release: 3%{?dist}' should be 'Release: 1%{?dist}' and your changelog entry > doesn't match the release. > https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs ChangeLog entry fixed. This release 3 is because there is libirman of this release in my repository and I need updates from this version. > [fab@laptop024 i386]$ rpmlint libirman* > libirman.i386: W: incoherent-version-in-changelog 0.4.4-2 ['0.4.4-3.fc9', > '0.4.4-3'] > 3 packages and 0 specfiles checked; 0 errors, 1 warnings. Thanks. For info. > - URL should point to the website of the upstream project. Why not > http://www.lirc.org/ ? I think lirc is not upstream for this, it's just required by this package. But if you stand that this URL is better, I can change it. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review