[Bug 469548] Review Request: ap-utils - Configure and monitor Wireless Access Points

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=469548





--- Comment #3 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx>  2008-12-06 08:04:24 EDT ---
(In reply to comment #1)
> The package must successfully compile and build into binary rpms.
>    - OK, on my Fedora 9/X86_64 box. Lots of compiler warnings " warning: 
>      pointer targets in assignment differ in signedness" while building."
>      for constructs with  a short and a literal #define int.
>      Seems acceptable to me. (Upstream report?)

I have seen those warning but I don't know to fix them.  I sent a message to
their mailing list. Waiting for an answer.

> A package must own all directories that it creates
>    - NOK. The %doc section lists  Documentation/*.html Documentation/FAQ
>      but these are not present at all in the generated RPM.

[fab@laptop024 i386]$ rpmls ap-utils-1.5-1.fc9.i386.rpm 
-rwxr-xr-x  /usr/bin/ap-auth
-rwxr-xr-x  /usr/bin/ap-config
-rwxr-xr-x  /usr/bin/ap-gl
-rwxr-xr-x  /usr/bin/ap-mrtg
-rwxr-xr-x  /usr/bin/ap-rrd
-rwxr-xr-x  /usr/bin/ap-tftp
-rwxr-xr-x  /usr/sbin/ap-trapd
drwxr-xr-x  /usr/share/doc/ap-utils-1.5
-rw-r--r--  /usr/share/doc/ap-utils-1.5/ABOUT-NLS
-rw-r--r--  /usr/share/doc/ap-utils-1.5/AUTHORS
-rw-r--r--  /usr/share/doc/ap-utils-1.5/COPYING
-rw-r--r--  /usr/share/doc/ap-utils-1.5/ChangeLog
-rw-r--r--  /usr/share/doc/ap-utils-1.5/FAQ  <---
-rw-r--r--  /usr/share/doc/ap-utils-1.5/NEWS
-rw-r--r--  /usr/share/doc/ap-utils-1.5/Ovislink-HOWTO.html  <---
-rw-r--r--  /usr/share/doc/ap-utils-1.5/README
-rw-r--r--  /usr/share/doc/ap-utils-1.5/THANKS
-rw-r--r--  /usr/share/doc/ap-utils-1.5/TODO
-rw-r--r--  /usr/share/locale/fr/LC_MESSAGES/ap-utils.mo
-rw-r--r--  /usr/share/locale/nl/LC_MESSAGES/ap-utils.mo
-rw-r--r--  /usr/share/locale/pl/LC_MESSAGES/ap-utils.mo
-rw-r--r--  /usr/share/locale/ro/LC_MESSAGES/ap-utils.mo
-rw-r--r--  /usr/share/locale/tr/LC_MESSAGES/ap-utils.mo
-rw-r--r--  /usr/share/locale/uk/LC_MESSAGES/ap-utils.mo
-rw-r--r--  /usr/share/man/man8/ap-auth.8.gz
-rw-r--r--  /usr/share/man/man8/ap-config.8.gz
-rw-r--r--  /usr/share/man/man8/ap-gl.8.gz
-rw-r--r--  /usr/share/man/man8/ap-mrtg.8.gz
-rw-r--r--  /usr/share/man/man8/ap-tftp.8.gz
-rw-r--r--  /usr/share/man/man8/ap-trapd.8.gz

> Large documentation files should go in a -doc subpackage
>    - TBD (Havn't seen those HTML files yet).

see above.  It's only one html file.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]