Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=474737 Matt Domsch <matt_domsch@xxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |matt_domsch@xxxxxxxx Flag| |fedora-review+ --- Comment #2 from Matt Domsch <matt_domsch@xxxxxxxx> 2008-12-04 23:43:14 EDT --- Easy review, as this is a small package with a clean script. BuildRoot line could be one of the more preferred items, but matters little with newer rpm 4.6. Also s/CVS/SCM/ in the comments. Both are trivial and can be fixed on CVS import. naming: ok legal: ok tags: ok rpmlint: no warnings or errors Comment in spec about license, site points to latest copy of GPL, so presumably they mean to do so. Therefore v3+ is appropriate. nothing else special about the package. clean file list, permissions. Byte-compiled python stuff is just for testing, and is in %{_datadir}. APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review