Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467489 Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |orcanbahri@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |orcanbahri@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-12-04 01:59:25 EDT --- Here are the results of my review on this package: * rpmlint says: nwsclient.noarch: W: non-executable-in-bin /usr/bin/PythonNWSSleighWorker.pyc 0644 nwsclient.noarch: W: non-executable-in-bin /usr/bin/PythonNWSSleighWorker.pyo 0644 These files should be excluded. Please see: http://fedoraproject.org/wiki/Packaging/Python#Unnecessary_Byte_compilation * Since this package is a python module, we have to obey the python module naming guidelines: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29 ? Shall we package the README* files? ? Why is only a subset of the scripts in the scripts directory installed? ? It would be nice if you make a %check section and run as many possible tests as possible from the test directory. * Source0 gives 404 * Providing Eggs for non-setuptools packages is slightly different than for setuptools packages. Please follow: http://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_for_non-setuptools_packages -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review