Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=473447 Marcela Maslanova <mmaslano@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mmaslano@xxxxxxxxxx --- Comment #1 from Marcela Maslanova <mmaslano@xxxxxxxxxx> 2008-12-03 09:50:09 EDT --- OK source files match upstream OK package meets naming and versioning guidelines. OK specfile is properly named, is cleanly written and uses macros consistently. OK dist tag is present. OK build root is correct. ? license field matches the actual license. OK license is open source-compatible. License text not included upstream. OK latest version is being packaged. OK BuildRequires are proper. OK %clean is present. OK package builds in mock (Rawhide/x86_64). OK debuginfo package isn't need. OK rpmlint is silent. OK final provides and requires look sane. OK no shared libraries are added to the regular linker search paths. OK owns the directories it creates. OK no duplicates in %files. OK file permissions are appropriate. OK no scriptlets present. OK code, not content. OK documentation is small, so no -docs subpackage is necessary. ? %docs are not necessary for the proper functioning of the package. OK no headers. OK no pkgconfig files. OK no libtool .la droppings. Shouldn't you install %{vimfiles}/doc/perlsupport.txt into %doc? I didn't find license anywhere in the package. Where could I check it? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review