Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=452584 --- Comment #14 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2008-12-01 18:17:43 EDT --- Some further comments. $ rpmlint /var/lib/mock//fedora-rawhide-i386/result mldonkey-server.i386: E: executable-marked-as-config-file /etc/sysconfig/mldonkey Please fix: install -D -p -m 755 packages/rpm/mldonkey.sysconfig $RPM_BUILD_ROOT%{_sysconfdir}/sysconfig/mldonkey Change 755 to 644. mldonkey-server.i386: E: script-without-shebang /etc/sysconfig/mldonkey mldonkey-server.i386: W: non-standard-uid /var/lib/mldonkey mldonkey mldonkey-server.i386: W: non-standard-gid /var/lib/mldonkey mldonkey mldonkey-server.i386: E: non-standard-dir-perm /var/lib/mldonkey 0750 mldonkey-server.i386: W: non-standard-uid /var/lib/mldonkey/incoming mldonkey mldonkey-server.i386: W: non-standard-gid /var/lib/mldonkey/incoming mldonkey mldonkey-server.i386: E: non-standard-dir-perm /var/lib/mldonkey/incoming 0770 mldonkey-server.i386: W: non-standard-uid /var/cache/mldonkey mldonkey mldonkey-server.i386: W: non-standard-gid /var/cache/mldonkey mldonkey mldonkey-server.i386: E: non-standard-dir-perm /var/cache/mldonkey 0750 mldonkey-server.i386: E: incoherent-logrotate-file /etc/logrotate.d/mldonkey mldonkey-server.i386: W: non-standard-uid /var/log/mldonkey mldonkey mldonkey-server.i386: W: non-standard-gid /var/log/mldonkey mldonkey mldonkey-server.i386: E: non-standard-dir-perm /var/log/mldonkey 0750 mldonkey-server.i386: W: incoherent-init-script-name mldonkey mldonkey.src: W: mixed-use-of-spaces-and-tabs (spaces: line 41, tab: line 1) 7 packages and 0 specfiles checked; 7 errors, 10 warnings. The rest can be ignored. mldonkey.spec: BuildRequires: m4 BuildRequires: autoconf Why does it need these two? Shouldn't the -gui subpackage require the main package? Or can it function independently? sed -i 's|\r||g' distrib/ed2k_submit/README.MLdonkeySubmit sed -i 's|\r||g' docs/slavanap.txt iconv -f iso8859-1 -t UTF-8 docs/gnutella.txt > docs/gnutella.utf8 && mv docs/gnutella.{utf8,txt} iconv -f iso8859-1 -t UTF-8 distrib/Authors.txt > distrib/Authors.utf8 && mv distrib/Authors.{utf8,txt} This doesn't preserve original file timestamps. Please use touch -r to do that. [...] # menu and pixmaps install packages/rpm/mldonkey-icon-16.png -D -m 644 $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/16x16/apps/mldonkey.png install packages/rpm/mldonkey-icon-32.png -D -m 644 $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/32x32/apps/mldonkey.png install packages/rpm/mldonkey-icon-48.png -D -m 644 $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/48x48/apps/mldonkey.png I suggest a loop: for sz in 16 32 48 ; do install packages/rpm/mldonkey-icon-${sz}.png -D -m 644 $RPM_BUILD_ROOT%{_datadir}/icons/hicolor/${sz}x${sz}/apps/mldonkey.png done %files ... %{_bindir}/copysources %{_bindir}/get_range %{_bindir}/make_torrent ... %{_bindir}/subconv %{_bindir}/svg_converter These filenames seem a little too generic. Are they supposed to be run by the user? Could you add a "ml" prefix to them? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review