Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469134 --- Comment #4 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-11-30 18:25:21 EDT --- Thanks, (In reply to comment #3) > I'm not sure about the dependencies for the default archivers - wouldn't things > just work for them with triggers as well? I'd personally remove them and do > everything with triggers, but if you want to keep the default set, I think it > would be good to add rpm to it - it's quite likely that it is installed on > Fedora systems. > I opted to make a "default archivers" list for simplicity. The script has to be more complicated for such cases as: - the user has tar and gz but not bz2 In such a case I have to use smart nested if-clauses for the trigger functions of bz2 and tar. Since a user who wants to deal with archives will probably have all of these archivers anyways and they are all loaded by most installations, I don't think it is worth the trouble to make the code to so complicated. > In any case, it would be good to own everything that is not actually installed > as usual in /var/lib/deco using %ghost. See the bash-completion package for an > example how to do this. I tried doing this. But I couldn't figure out how to escape the special characters such as [ { ) in the filenames in the %files section. The obvious \[ \{ etc. escapes don't work. Here is what I did: SPEC: http://oget.fedorapeople.org/review/deco-archive.spec SRPM: http://oget.fedorapeople.org/review/deco-archive-1.2-4.fc10.src.rpm Note that this SRPM does not build. It fails with: RPM build errors: File not found by glob: /home/orcan/rpmbuild/BUILDROOT/deco-archive-1.2-4.fc10.x86_64/var/lib/deco/7z\.[0-9]{2,} File not found by glob: /home/orcan/rpmbuild/BUILDROOT/deco-archive-1.2-4.fc10.x86_64/var/lib/deco/ace|[c0-9][0-9]{2} File not found by glob: /home/orcan/rpmbuild/BUILDROOT/deco-archive-1.2-4.fc10.x86_64/var/lib/deco/part[0-9]+\.rar File not found by glob: /home/orcan/rpmbuild/BUILDROOT/deco-archive-1.2-4.fc10.x86_64/var/lib/deco/rar|[rst][0-9]{2} File not found by glob: /home/orcan/rpmbuild/BUILDROOT/deco-archive-1.2-4.fc10.x86_64/var/lib/deco/t7z\.[0-9]{2,} File not found by glob: /home/orcan/rpmbuild/BUILDROOT/deco-archive-1.2-4.fc10.x86_64/var/lib/deco/tar\.7z\.[0-9]{2,} I asked about this to many people but nobody could figure this out. Any suggestions? Also the SPEC file is kind of ugly right now. I don't know how to simplify the part with ( if x$i="xbz2" || x$i="xcpio" ||...|| x$i="xtar" ) in the %install section and also the %{_var}/lib/deco/bz2 %{_var}/lib/deco/cpio ... %{_var}/lib/deco/tar part in the %files section. > > There's something wrong with for example the tar.lzma trigger. For me it > installs a symlink: "/var/lib/deco/tar.lzma -> > ../../../usr/share/deco-archive/tar.lzma" which is broken - there's no > "tar.lzma" in /usr/share/deco-archive here. "tar\.lzma" on the other hand is > there, and I suppose "tar\.lzma" should be in /var/lib/deco instead of > "tar.lzma" as well. At least the unrar and p7zip triggers could have a similar > problem, maybe others with special chars as well. Thanks for the catch. Yes, there was a problem with tar\.lzma. The others are fine as far as I tested. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review