Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472848 --- Comment #21 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2008-11-30 09:48:15 EDT --- (In reply to comment #17) > This build contains more fixes, as well as including the jeuclid-fod and > jeuclid-mathviewer subpackages. I cannot build the jeuclid-cli until > commons-cli is updated bug 473373 . I have had to write a new build script > based on the Debian one as the ones included do not work well with fedora > package build structure. I still need to do the GUI stuff for > jeclid-mathviewer. > > SRPM: http://bashton.fedorapeople.org/jeuclid-3.1.3-7.fc9.src.rpm > SPEC: http://bashton.fedorapeople.org/jeuclid.spec This specfile is older than the one in the src.rpm. Requires: fop = 0.95 Does it work only with this version? Will it have to be rebuilt when fop is upgraded to a newer version? (cd $RPM_BUILD_ROOT%{_javadir} && for jar in *-%{version}*; do ln -sf ${jar} `echo $jar| sed "s|-%{version}||g"`; done) This could be rewritten as: pushd $RPM_BUILD_ROOT%{_javadir} for jar in *-%{version}*; do ln -sf ${jar} `echo $jar| sed "s|-%{version}||g"` done popd Which is more readable IMHO, but I'm not insisting on it. Also, the usage of '|' in sed expression is a bit unusual. I suggest plain slash ('/') instead. It looks very nice otherwise. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review