Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462163 --- Comment #15 from John Guthrie <guthrie@xxxxxxxxxxxxxxxxxx> 2008-11-28 00:46:46 EDT --- (In reply to comment #14) > === Final Notes === > 1. Please do not use userdel in %post. The Fedora policy is to allow the > sysadmin to clean at will, if/when needed. > 2. Since you are using RPM_BUILD_ROOT in a lot of places, please replace > %{optflags} with its uppercase equivalent. Technically we are OK, but > estethically we are not. > > Please make the above mentioned 2 modifications and we are good to go. I have made both of these modifications: Spec URL: http://www.guthrie.info/RPMS/f9/checkdns.spec SRPM URL: http://www.guthrie.info/RPMS/f9/checkdns-0.5-7.fc9.src.rpm Thank you very much. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review