[Bug 473205] Review Request: gPlanarity - puzzle game

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=473205





--- Comment #2 from Brennan Ashton <bashton@xxxxxxxxxxxxxxxxx>  2008-11-27 02:23:39 EDT ---
A few things that need to be fixed:
* This is a GUI app so:
https://fedoraproject.org/wiki/PackagingGuidelines#Desktop_files
* You need to have the requires in there, wont run with out the X stuff
* Your build root looks odd should be:
BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
* Just remove #%%configure 


And remember to put a change log entry and +1 the release when you submit the
new spec and SRPM

Also if you want I can co-maintain this when you get it approved.  Glad I was
able to help you though this one, the first always seems to take forever to
write.
You will still need to wait for a sponsor to come by and do the full review for
you. In the meantime you will need to package at least one more package and do
a review or two, they will not just sponsor you for one package.  Feel free to
pull something off the wish list
https://fedoraproject.org/wiki/PackageMaintainers/WishList if you do not have
anything in mind.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]