Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472848 Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |rpm@xxxxxxxxxxxxxx Flag| |fedora-review? --- Comment #4 from Dominik 'Rathann' Mierzejewski <rpm@xxxxxxxxxxxxxx> 2008-11-26 06:13:02 EDT --- Good, but you should post the link to the updated spec file and src.rpm after you've made the changes (also increase the Release: tag and describe your changes in %changelog). You still haven't addressed this: jeuclid-core.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/jeuclid-core-3.1.3/NOTICE It is admittedly minor, but please fix that by converting the file using tr, sed or perl in %prep. Remember to preserve the original file's timestamp using touch. I will try and complete the review tonight. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review