Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472676 Jon Ciesla <limb@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |limb@xxxxxxxxxxxx Flag| |fedora-review? --- Comment #7 from Jon Ciesla <limb@xxxxxxxxxxxx> 2008-11-25 08:44:05 EDT --- Ok. Also, probably best to use NoArch instead of BuildArch, so sparc, alpha, etc can take a crack at it later. rpmlint on SRPM: partimage.src: W: strange-permission create_certificates.sh 0775 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. partimage.src: W: strange-permission partimaged-passwd 0755 A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. Should these not be 700, or at least 744? rpmlint on RPMS: partimage-server.i386: W: non-standard-uid /etc/partimaged partimag partimage-server.i386: W: non-standard-gid /etc/partimaged partimag partimage-server.i386: W: non-standard-uid /home/images partimag partimage-server.i386: W: non-standard-gid /home/images partimag partimage-server.i386: W: non-standard-uid /var/log/partimaged partimag partimage-server.i386: W: non-standard-gid /var/log/partimaged partimag partimage-server.i386: W: non-standard-uid /etc/partimaged/create_certificates.sh partimag partimage-server.i386: W: non-standard-gid /etc/partimaged/create_certificates.sh partimag partimage-server.i386: W: non-standard-uid /etc/partimaged/partimagedusers partimag partimage-server.i386: W: non-standard-gid /etc/partimaged/partimagedusers partimag partimage-server.i386: W: non-standard-uid /etc/partimaged/partimage-certs.cnf partimag partimage-server.i386: W: non-standard-gid /etc/partimaged/partimage-certs.cnf partimag OK. partimage-server.i386: E: dir-or-file-in-home /home/images What's going on here? This cannot be in /home, maybe /usr/share/partimage-server or /var/lib/partimage-server. partimage-server.i386: E: incoherent-logrotate-file /etc/logrotate.d/partimaged partimage-server.i386: W: incoherent-init-script-name partimaged Probably fine, but could be patched to be partimage-server, or possibly the sub-package renamed partimaged. partimage-server.i386: E: executable-marked-as-config-file /etc/partimaged/create_certificates.sh Should be in /usr/share/partimaged/ partimage-server.i386: E: non-readable /etc/partimaged/partimagedusers 0600 Probably fine. Full review in progress. . . -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review