Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470792 --- Comment #2 from Alexander Kurtakov <akurtako@xxxxxxxxxx> 2008-11-25 04:40:34 EDT --- Updated with the comments Spec URL: http://akurtakov.fedorapeople.org/eclipse-shelled.spec SRPM URL: http://akurtakov.fedorapeople.org/eclipse-shelled-1.0.3-1.fc9.src.rpm (In reply to comment #1) > I made a quick check. There is this issue that needs to be corrected before we > can do a full review: > > * Source0 must be given in full URL from upstream's website. Done: Fetch script added. > > > A few other things that I caught were: > > * For the Group tag pick something from > /usr/share/doc/rpm-*/GROUPS > Development/Tools or Development/Languages maybe? Done: Development/Tools > > * %eclipse_base must be > %define eclipse_base %{_datadir}/eclipse > Check: http://fedoraproject.org/wiki/Packaging/EclipsePlugins > Otherwise the package will not build. Not valid for Fedora 10. > > * No %doc files? Check the source thoroughly. Please list every applicable file > in %doc. There is really no doc provided. > > * Use CPL for the license Done. > > * There shouldn't be both spaces and tabs in the same SPEC file. Please use one > or the other. rpmlint is a good application which will warn you about such > things and many other issues. Fixed. Rpmlint do not show any warning. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review