Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469897 Felix Kaechele <felix@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |felix@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |felix@xxxxxxxxxx Flag| |fedora-review? --- Comment #2 from Felix Kaechele <felix@xxxxxxxxxx> 2008-11-23 07:23:17 EDT --- Looks good so far. Only thing I see is that you didn't comment on the patches within the SPEC file. Could you please add a comment wether you filed a bug with upstream already or if this patches are Fedora specific. Also see https://fedoraproject.org/wiki/Packaging/Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment Also I'll be taking this bug for review now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review