Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472664 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |panemade@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flag| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-11-23 06:02:50 EDT --- Review: + package builds in mock (rawhide i386). koji build=> http://koji.fedoraproject.org/koji/taskinfo?taskID=946153 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 2867824be9cbe3e86e94ca677d042ffe HTML-TokeParser-Simple-3.15.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test outputs All tests successful. Files=7, Tests=188, 0 wallclock secs ( 0.04 usr 0.01 sys + 0.50 cusr 0.04 csys = 0.59 CPU) + Package perl-HTML-TokeParser-Simple-3.15-1.fc11 => Provides: perl(HTML::TokeParser::Simple) = 3.15 perl(HTML::TokeParser::Simple::Token) = 3.0 perl(HTML::TokeParser::Simple::Token::Comment) = 1.0 perl(HTML::TokeParser::Simple::Token::Declaration) = 1.0 perl(HTML::TokeParser::Simple::Token::ProcessInstruction) = 2.0 perl(HTML::TokeParser::Simple::Token::Tag) = 1.2 perl(HTML::TokeParser::Simple::Token::Tag::End) = 1.0 perl(HTML::TokeParser::Simple::Token::Tag::Start) = 1.0 perl(HTML::TokeParser::Simple::Token::Text) = 1.0 Requires: perl(HTML::Entities) perl(HTML::TokeParser) perl(HTML::TokeParser::Simple::Token) perl(HTML::TokeParser::Simple::Token::Comment) perl(HTML::TokeParser::Simple::Token::Declaration) perl(HTML::TokeParser::Simple::Token::ProcessInstruction) perl(HTML::TokeParser::Simple::Token::Tag) perl(HTML::TokeParser::Simple::Token::Tag::End) perl(HTML::TokeParser::Simple::Token::Tag::Start) perl(HTML::TokeParser::Simple::Token::Text) perl(base) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review