Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=465646 Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |orcanbahri@xxxxxxxxx --- Comment #1 from Orcan 'oget' Ogetbil <orcanbahri@xxxxxxxxx> 2008-11-22 14:21:15 EDT --- I reviewed this package. Here are my notes : * The package must obey python modules naming guidelines: Please see: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29 And the spec file will need to be renamed accordingly. * Latest version is not packaged. Please update to the latest version. * You should probably make a %check section and run the tests given in the test_doc.py * There is a doc directory in the tarball. Should (at least, some of) the contents of that directory be packaged? * You must have BuildRequires: python-setuptools-devel Please see: http://fedoraproject.org/wiki/Packaging/Python/Eggs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review