Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=438811 Lev Shamardin <shamardin@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |shamardin@xxxxxxxxx --- Comment #2 from Lev Shamardin <shamardin@xxxxxxxxx> 2008-11-22 07:16:01 EDT --- I'm not a sponsor, so this is not a formal review, but I hope this can speed things up a bit. - FAILED: rpmlint complaints: php-pear-HTML-AJAX.spec: W: mixed-use-of-spaces-and-tabs (spaces: line 4, tab: line 50) You shoud use spaces for indentation. Just expand all tabs. php-pear-HTML-AJAX.noarch: W: file-not-utf8 /usr/share/doc/php-pear-HTML-AJAX-0.5.2/examples/proxy_usage_server.php php-pear-HTML-AJAX.noarch: W: file-not-utf8 /usr/share/doc/php-pear-HTML-AJAX-0.5.2/examples/support/test.class.php I see that you've tried to fix this issue in the %install script, but you are iconv'ing wrong files. You should iconv files in docdir/%{pear_name}/examples/ - PASSED: The package is named according to the Package Naming Guidelines. - PASSED: Spec file name is ok. - FAILED: The package dos not meet the Packaging Guidelines for PHP. Please check with https://fedoraproject.org/wiki/Packaging/PHP A PEAR package MUST have: BuildRequires: php-pear(PEAR) Requires: php-pear(PEAR) Requires(post): %{__pear} Requires(postun): %{__pear} Provides: php-pear(foo) = %{version} post-scriptlets are fine. - PASSED: The license is fedora-compatible. - FAILED: The license specified on the project homepage is LGPL, the license specified in spec file is LGPLv3. - PASSED: The spec file is written in American English in legible. - PASSED: The sources match the upstream source (md5 verified). - PASSED: The package may be successfully built. - FAILED: Not all build build dependencies are listed in BuildRequires. You should add at least dos2unix. - FAILED: The package does not build in mock due to missing BuildRequires. - PASSED: A package does not contain any duplicate files in the %files listing. - PASSED: Permissions are sane. - PASSED: %clean section is fine. - PASSED: macros usage is fine. - PASSED: The package must contains code. - PASSED: The package does not contain large documentation. - PASSED: %doc contents is fine. - FAILED: This package owns directory /usr/share/pear/HTML. It is already owned by php-pear-HTML-Common, so this package must Require it, and own only it's own subdirectory in /usr/share/pear/HTML. - PASSED: There is rm -rf $RPM_BUILD_ROOT in the beginning of %install. - PASSED: All filenames in rpm package are valid UTF-8. Some other general notes: You are packaging version 0.5.2 of the package which is a beta. There is a newer upstream beta available. Could you please justify why are you packaging an older release, or please upgrade to the newer upstream version. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review