Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=459637 --- Comment #3 from Lucian Langa <cooly@xxxxxxxxxxxx> 2008-11-21 08:02:53 EDT --- (In reply to comment #2) > --- Compiling SpanDtmfDecoder.cpp... > /usr/include/spandsp/dtmf.h: In member function 'virtual bool > SpanDtmfDecoder::initialize()': > /usr/include/spandsp/dtmf.h:228: error: too few arguments to function 'void > dtmf_rx_parms(dtmf_rx_state_t*, int, int, int, int)' > SpanDtmfDecoder.cpp:169: error: at this point in file Patch2 was not applied. Fixed. > Also, the build system obscures the compiler calls, but I'm not sure I see any > place that would incorporate the regular Fedora compiler flags. There's no > mention of %{optflags} or $RPM_OPT_FLAGS in the spec and there's no configure > script to call. Fixed. A few notes: rpmlint libasync.x86_64: W: shared-lib-calls-exit /usr/lib64/libasyncaudio-0.16.1.so exit@xxxxxxxxxxx libasync.x86_64: W: shared-lib-calls-exit /usr/lib64/libasynccpp-0.16.1.so exit@xxxxxxxxxxx libasync-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libasyncaudio-0.16.1.so exit@xxxxxxxxxxx libasync-devel.x86_64: W: shared-lib-calls-exit /usr/lib64/libasynccpp-0.16.1.so exit@xxxxxxxxxxx Not entirely sure but I think it safe. >From what I could see there are 2 calls both internal error handling. I will address this upstream anyway. libasync.x86_64: W: unused-direct-shlib-dependency libasync-devel.x86_64: W: unused-direct-shlib-dependency I am unable to fix, package does not use libtool and passing -Wl,-as-needed won't work (fails with undefined reference) I think the above are harmless. new version: http://lucilanga.fedorapeople.org/svxlink.spec http://lucilanga.fedorapeople.org/svxlink-080730-3.fc10.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review