Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472337 --- Comment #3 from Silas Sewell <silas@xxxxxxxxx> 2008-11-20 10:32:42 EDT --- (In reply to comment #1) > - 'License: GPLv2' The license should be GPLv2+. Take a look at the headers of > the source: "or (at your option) any later version" Fixed. > - Replace 'BuildRequires: python-devel' with 'BuildRequires: python' > https://fedoraproject.org/wiki/Packaging/Python#BuildRequires Fixed. > - Do you really need 'Requires: python-setuptools' ? Yes, it is a requirement. > - add TODO to %doc Fixed. > - 'Requires: python-paramiko < 2' is from my point of view not necessary > because the current version of paramiko is 1.7.4 Fixed (the only reason I added this was because it was explicitly set in the egg). Thanks for your feedback. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review