[Bug 459874] Review Request: zeromq - Fast messaging system

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=459874





--- Comment #10 from Peter Lemenkov <lemenkov@xxxxxxxxx>  2008-11-19 10:59:09 EDT ---
(In reply to comment #9)
> This fails to build; autoreconf is called without any build dependency on the
> autotools.  Some people insist that autotools should never be called as part of
> a package build; I'm not one of them, but it seems a waste for that one line
> change.  Do you know how much change there is in the resulting Makefile?  Maybe
> you could just patch that instead.  Or, I guess, fix the build dependency.

Added autoconf as a BiuldRequires.

I don't want to fix makefile instead of rebuilding it, because my patch already
accepted upstream. Next release (0.4 - scheduled on next week)  will include
this fix.

> The descriptive texts are better now; the only notes I'd make are
> s/standarts/standards/ in the main package %description and terminate
> %description lines with periods.

Done.

http://peter.fedorapeople.org/zeromq.spec
http://peter.fedorapeople.org/zeromq-0.3.2-3.fc9.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]