Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471575 --- Comment #7 from Alec Leamas <leamas.alec@xxxxxxxxx> 2008-11-19 08:16:38 EDT --- Made a new version. The issues you mentioned fixed, besides: - Trying to find a balance in when to define macros I have removed %pkg and %pkgdatadir, but kept %schemadir, %plugindir and %download_url. If you insist, I'll remove them. But I feel they make things a better e. g., by making the scriptlets a bit more more concise. And personally, I avoid source lines > 72 chars; hence %download_url - gettext-devel still there (see above). - And still svn-based revision. I'm not stubborn, but a little interested what the arguments are in a situation when the spec file release is the same as the source release... The reasons to stick to svn # are obvious, but I don't have to complete picture. New spec url: http://downloads.sourceforge.net/dt-contacts/libnautilus-vcards-48M.spec (The filename is bad, a cludge to handle sf limitations) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review