Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472060 Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fabian@xxxxxxxxxxxxxxxxx --- Comment #1 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2008-11-19 07:14:42 EDT --- Just some quick comments on your spec file. Some changes will make your life easier in the future because there will be less pain for maintaining ;-) - You can use 'Source0: http://downloads.sourceforge.net/%{name}/%{name}-%{version}-1.tar.gz' instead of 'Source0: http://downloads.sourceforge.net/mumbles/mumbles_0.4-1.tar.gz' - 'BuildRequires: python-devel' should be 'BuildRequires: python' https://fedoraproject.org/wiki/Packaging/Python#BuildRequires - 'BuildRequires: python-setuptools' should be 'BuildRequires: python-setuptools-devel' https://fedoraproject.org/wiki/Packaging/Python/Eggs#Providing_Eggs_using_Setuptools - Replace '%setup -q -n mumbles-0.4' with '%setup -q -n %{name}-%{version}' - The vendor tag for .desktop file is no longer used for new packages. See https://fedoraproject.org/wiki/TomCallaway/DesktopFileVendor Don't forget to change %{_datadir}/applications/fedora-%{name}.desktop - Add AUTHORS PKG-INFO README to %doc - Shouldn't '%{_datadir}/%{name}' be '%{_datadir}/%{name}/' and '%{python_sitelib}/mumbles' be '%{python_sitelib}/mumbles/'? There is a mixture of macros and the name. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review