Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=472165 --- Comment #3 from Parag AN(पराग) <panemade@xxxxxxxxx> 2008-11-19 04:28:24 EDT --- sorry I mixed other perl package review with this. Review: + package builds in mock (rawhide i386). koji Build => http://koji.fedoraproject.org/koji/taskinfo?taskID=939617 + rpmlint is silent for SRPM and for RPM. + source files match upstream url 34837b2bfabf73f7169bbfa4d00a403c Test-Strict-0.09.tar.gz + package meets naming and packaging guidelines. + specfile is properly named, is cleanly written + Spec file is written in American English. + Spec file is legible. + dist tag is present. + build root is correct. + license is open source-compatible. + License text is included in package. + %doc is present. + BuildRequires are proper. + %clean is present. + package installed properly. + Macro use appears rather consistent. + Package contains code, not content. + no headers or static libraries. + no .pc file present. + no -devel subpackage + no .la files. + no translations are available + Does owns the directories it creates. + no scriptlets present. + no duplicates in %files. + file permissions are appropriate. + make test gave All tests successful. Files=5, Tests=40, 7 wallclock secs ( 0.03 usr 0.00 sys + 7.09 cusr 0.36 csys = 7.48 CPU) + Package perl-Test-Strict-0.09-1.fc11 Provides: perl(Test::Strict) = 0.09 Requires: perl >= 0:5.004 perl(File::Find) perl(File::Spec) perl(FindBin) perl(Test::Builder) perl(strict) perl(vars) APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review