Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=462529 Brian Pepple <bdpepple@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #1 from Brian Pepple <bdpepple@xxxxxxxxx> 2008-11-16 17:19:48 EDT --- MD5Sum: 38a2d25a32409402995d624cbc7a5b39 feedcache-1.3.tar.gz Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All necessary BuildRequires listed. * Package builds in Mock. * Package installs and uninstalls cleanly Bad: * rpmlint produces the following errors which should be reviewed/corrected before importing into CVS: python-feedcache.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/feedcache/cachestoragelock.py 0644 python-feedcache.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/feedcache/__init__.py 0644 python-feedcache.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/feedcache/test_cachestoragelock.py 0644 python-feedcache.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/feedcache/test_cache.py 0644 python-feedcache.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/feedcache/cache.py 0644 python-feedcache.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/feedcache/test_server.py 0644 python-feedcache.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/feedcache/example.py 0644 python-feedcache.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/feedcache/example_threads.py 0644 python-feedcache.noarch: E: non-executable-script /usr/lib/python2.5/site-packages/feedcache/test_shovefilesystem.py 0644 +1 APPROVED (once those rpmlint errors are looked at) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review