Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470547 Alec Leamas <leamas.alec@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |leamas.alec@xxxxxxxxx --- Comment #3 from Alec Leamas <leamas.alec@xxxxxxxxx> 2008-11-16 03:15:50 EDT --- Hi! Unfortunately, I'm not a reviewer... But according to the instructions, I need to show some interest in reviewing other requests in order to get a sponsor. So I'll do that. Please feel free to do the same for me, my request is bug 471575 :-) For me, rpmlint gives the following semi.src: E: no-buildroot-tag semi.src: W: mixed-use-of-spaces-and-tabs (spaces: line 15, tab: line 2) semi.src: W: non-standard-group Unspecified semi.src: W: invalid-license GPL My mock build bails out, complaining about the missing Group: field. I think all of these issues should be closed. Copyright & license. Most (all?) files have a nice GPLv2 copyright notice. However, the I really miss the top-level file COPYING - the notices refer to this. I think it should be part of the package. See more below > #%define _default_patch_fuzz 2 > %define _semiver 1.14.6 > %define _flimver 1.14.8 > %define _emacsver 22.2 > > %define _lispdir %{_datadir}/emacs/site-lisp > > Summary: Library to provide MIME feature for GNU Emacs > Name: semi > Version: %{_semiver} > Release: 1%{?dist} > License: GPL > #Group: Applications/Internet As lint says, there need to be a valid group and license tag. As for license, see http://fedoraproject.org/wiki/Licensing - I think it boils down to GPLv2. For Group:, take a look at http://koti.welho.com/vskytta/packagers-handbook/packagers-handbook.html#guidelines-group-tag > URL: ftp://ftp.m17n.org/pub/mule/semi/semi-1.14-for-flim-1.14 > Source0: ftp://ftp.m17n.org/pub/mule/semi/semi-1.14-for-flim-1.14/semi-%{version}.tar.bz2 Unfortunately, these are password protected. > BuildRequires: emacs >= %{_emacsver}, flim >= %{_flimver} > BuildArch: noarch > Requires: emacs >= %{_emacsver}, flim >= %{_flimver} > > Patch1: semi-001-use-w3m-instead-of-w3.patch > > %description > SEMI is a library to provide MIME feature for GNU Emacs. MIME is a > proposed internet standard for including content and headers other than > (ASCII) plain text in messages [nit-picking] This was written some time ago... Isn't it fair these days to say that MIME is the way to handle content on Internet? > > %prep > > %setup -q -n semi-%{version} > %patch1 -p1 > > # necessary to generate the auto-autoloads.el file: > touch *.el > > %build > > %install > > rm -rf %buildroot > > %{__mkdir_p} %buildroot%{_lispdir}/semi > > cd $RPM_BUILD_DIR/semi-%{version} > > make LISPDIR=%buildroot%{_lispdir} > make LISPDIR=%buildroot%{_lispdir} install > > make clean Why make clean here? If all goes well, %clean will take care of it. If not, I think we want everything. Or am I missing something? > > %clean > rm -rf %buildroot > > %files > %defattr(-,root,root) > %doc NEWS README* ChangeLog SEMI* TODO VERSION > %{_lispdir}/semi > > %changelog > > * Fri Nov 7 2008 Vitaly Mayatskikh <vmayatsk@xxxxxxxxxx> [1.14.6-1] > - first build > Cheers! --alec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review