Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=471522 --- Comment #4 from Peter Lemenkov <lemenkov@xxxxxxxxx> 2008-11-15 05:10:15 EDT --- Few additional remarks: * Add newline between %setup and %build (just cosmetic) * About renaming to otl-devel - although it's not a blocker I advise you to rename it back to otl. First, if some Fedora user will decide to play with otl, his first attempt will be "yum install otl". E.g. I strongly vote against naming of packages which differs from upstream ones w/o reasons. I can't find any reasons in your case. However some packages does prefer your current naming scheme. If you'll finally decide to stay with otl-devel, you should add "Provides: otl" to your spec-file. Please consider these two advices (of course, you may reject both - they're not a blocker issues) and I'll make a review. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review