Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469627 Jason Tibbitts <tibbs@xxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #4 from Jason Tibbitts <tibbs@xxxxxxxxxxx> 2008-11-14 09:20:04 EDT --- It's sad to add all of that cruft to the specfile just so you can include some test files which are simply not even remotely useful as documentation. Priorities, right? But, hey, it's your package. * source files match upstream: a80c5dc845a38867242edd2668db7ee8baa6126cd284b666ce2ed26fce30d5cd MooseX-Types-Path-Class-0.05.tar.gz * package meets naming and versioning guidelines. * specfile is properly named, is cleanly written and uses macros consistently. * summary is OK. * description is OK. * dist tag is present. * build root is OK. * license field matches the actual license. * license is open source-compatible. * license text not included upstream. * latest version is being packaged. * BuildRequires are proper. * %clean is present. * package builds in mock (rawhide, x86_64). * package installs properly. * rpmlint is silent. * final provides and requires are sane: perl(MooseX::Types::Path::Class) = 0.05 perl-MooseX-Types-Path-Class = 0.05-2.fc10 = perl(:MODULE_COMPAT_5.10.0) perl(MooseX::Types::Moose) perl(Path::Class) perl(strict) perl(warnings) * %check is present and all tests pass: All tests successful. Files=8, Tests=37, 3 wallclock secs ( 0.02 usr 0.02 sys + 1.03 cusr 0.11 csys = 1.18 CPU) * owns the directories it creates. * doesn't own any directories it shouldn't. * no duplicates in %files. * file permissions are appropriate. * no generically named files * code, not content. * documentation is small, so no -doc subpackage is necessary. * %docs are not necessary for the proper functioning of the package. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review