Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467655 --- Comment #27 from Paulo Roma Cavalcanti <promac@xxxxxxxxx> 2008-11-11 09:34:53 EDT --- (In reply to comment #26) > quick comments. I will have more time on wednesday... > > The snapshot is good, can be I've regenerated from today and the package built > fine. > > What need to be improved. > * The package release should notice it is a snapshot. So, either the version > (0.1.0) is pre, or post. then the release will be <1 (aka: > 0.1svn%{date}%{?dist} or >1 ( 1svn%{date}%{?dist}. Done. I used: 0.1.svn.%{date}%{?dist} > > * Package must use our $RPM_OPT_CFLAGS. > For now it use -O3 -ffast-math, you will probably need another dynamic patch > here as $RPM_OPT_CFLAGS depends on the cpu architecture. > > > * rpmlint on installed packages (rpmlint yafaray yafaray-blender) aren't empty, > specially there are a lot of undefined-non-weak-symbols. This is because of a > missing library at linking time, This have to be repored upstream. > /usr/lib64/_yafqt.so > /usr/lib64/_yafrayinterface.so This is what I get: [cascavel:~/SRPMS] rpmlint yafaray yafaray.x86_64: W: no-soname /usr/lib64/libyafaraycore.so yafaray.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libyafaraycore.so /usr/lib64/libIex.so.6 yafaray.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libyafaraycore.so /usr/lib64/libImath.so.6 yafaray.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libyafaraycore.so /lib64/libz.so.1 [cascavel:~/SRPMS] rpmlint yafaray-blender yafaray-blender.x86_64: E: wrong-script-interpreter /usr/share/blender/scripts/yafaray_ui.py "BPY" yafaray-blender.x86_64: E: non-executable-script /usr/share/blender/scripts/yafaray_ui.py 0644 yafaray-blender.x86_64: E: wrong-script-interpreter /usr/share/blender/scripts/yaf_export.py "BPY" yafaray-blender.x86_64: E: non-executable-script /usr/share/blender/scripts/yaf_export.py 0644 yafaray-blender.x86_64: E: wrong-script-interpreter /usr/share/blender/scripts/yaf_light.py "BPY" yafaray-blender.x86_64: E: non-executable-script /usr/share/blender/scripts/yaf_light.py 0644 yafaray-blender.x86_64: W: no-soname /usr/lib64/libyafarayqt.so yafaray-blender.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libyafarayqt.so /lib64/libm.so.6 yafaray-blender.x86_64: W: no-soname /usr/lib64/libyafarayplugin.so yafaray-blender.x86_64: W: unused-direct-shlib-dependency /usr/lib64/libyafarayplugin.so /lib64/libdl.so.2 1 packages and 0 specfiles checked; 6 errors, 4 warnings. > > * I still cannot have yarafray blender plugin detected when > blender-2.48a-4.fc8.x86_64 is used. I will ivestigate this, but maybe it would > be easier to define a blender python plugins directory within the python libdir > pathes. > > %{python_sitearch}/blender/ for architecture dependent plugin (like yafaray) > %{python_sitelib}/blender for architecture independant plugin. I put _yaf*.so in %{python_sitearch} and it also worked. Maybe this way you can get them detected. The scrpits (.py), I think they should go where the other blender scripts are: /usr/share/blender/scripts new URLs: http://people.atrpms.net/~pcavalcanti/specs/yafray.spec http://people.atrpms.net/~pcavalcanti/srpms/yafaray-0.1.0-0.1.svn.20081031.fc8.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review