Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=467641 Bryan Kearney <bkearney@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bkearney@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |bkearney@xxxxxxxxxx --- Comment #2 from Bryan Kearney <bkearney@xxxxxxxxxx> 2008-11-10 16:38:43 EDT --- Couple of things: OK - Package name OK - License info is accurate OK - License tag is correct and licenses are approved OK - License files are installed as %doc OK - Specfile name OK - Specfile is legible OK - No prebuilt binaries included OK - BuildRoot value (one of the recommended values) OK - PreReq not used ?? - Source md5sum matches upstream - Any chance of working with upstream to get the tarball pushed to http://dev.laptop.org/pub/sugar/sources/. Barring that can you modify the checkout to use a snapshot (http://dev.laptop.org/git?p=activities/maze;a=snapshot;h=ffdbd8e3232ad67a6a99134f1252c76a81dbe000) OK - No hardcoded pathnames OK - Package owns all the files it installs OK - 'Requires' create needed unowned directories OK - BuildRequires sufficient OK - File permissions set properly OK - Macro usage is consistent ?? - rpmlint is silent - rpmlint on the srpm shows this (the last 3 are worriesome) sugar-maze.src: W: non-standard-group Sugar/Activities sugar-maze.src: W: strange-permission sugar-maze-checkout.sh 0755 sugar-maze.src: W: strange-permission Maze-6.tar.bz2 0755 sugar-maze.src: W: strange-permission sugar-maze.spec 0755 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review