[Bug 467958] Review Request: barry - BlackBerry(tm) Desktop for Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467958





--- Comment #6 from Christopher D. Stover <quantumburnz@xxxxxxxxxxx>  2008-11-09 15:30:59 EDT ---
Hi Hans, thanks for the full review.  I didn't realize those directory
ownership issues were a problem before but I've read up on them and it makes
sense now.  Hopefully they should all be fixed now.  Output from rpmlint:
[Chris@localhost SPECS]$ rpmlint barry.spec
0 packages and 1 specfiles checked; 0 errors, 0 warnings.
[Chris@localhost SPECS]$ rpmlint ../RPMS/i386/barry*
5 packages and 0 specfiles checked; 0 errors, 0 warnings.

I moved the libs out of the main package and back into their own package again.
 I also put *.so in the devel package.

I added Requires: libopensync to the opensync package to make sure
%{_libdir}/opensync exists.

I cleaned up the doc directory -- removed *.sh and *.php which were used to
create the *.html files.

I added --disable-rpath to the %configure lines instead of the sed commands you
pasted.  I don't have a 64-bit machine to test on but can you let me know if
this fixes the problem?  If not, I'll have to use the sed commands.

SPEC:
http://8uxodw.bay.livefilestore.com/y1pzd9Tb3TfRlfB2LpwvfmZ4cu_zknwrn_D9-R9BaHNGIqgS355w_eUnWkcl8ZAFYbvTVArCdxuo4Q/barry.spec?download

SRPM:
http://8uxodw.bay.livefilestore.com/y1pzd9Tb3TfRlc7jRbx1-VYIoiOdC3wZL9botvMNwIskrSRYQmuAyM9wz5FosWRUw8TY1opI1uyiFk/barry-0.14-2.fc10.src.rpm?download

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]