Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=466301 --- Comment #7 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-11-09 12:49:45 EDT --- For -4: * More (Build)Requires fixes - "BuildRequires: gettext-devel" is excessive and "BuildRequires: gettext" is enough - "Requires: gettext" is not needed. * sed usage --------------------------------------------------------- sed s/ario.png/ario/ < %{buildroot}/%{_datadir}/applications/ario.desktop \ > %{buildroot}/%{_datadir}/applications/ario.desktop.new rm %{buildroot}/%{_datadir}/applications/ario.desktop mv %{buildroot}/%{_datadir}/applications/ario.desktop.new \ %{buildroot}/%{_datadir}/applications/ario.desktop --------------------------------------------------------- - First of all fixing data/ario.desktop.in.in at %prep instead of fixing installed ario.desktop is preferred (for --short-circuit issue) - Then you can -i option of sed. --------------------------------------------------------- sed -i -e 's|ario\.png|ario|' data/ario.desktop.in.in --------------------------------------------------------- * libtool .la files - Usually installed libtool .la files _must_ be removed. https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries * %find_lang - The comment --------------------------------------------------------- # At some point it might be a good move to use %lang(xx) for the locales --------------------------------------------------------- is no longer needed because %find_lang actually does this (you can check the contents of Ario.lang) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review