Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=470694 --- Comment #2 from Jeroen van Meeuwen <kanarip@xxxxxxxxxxx> 2008-11-09 09:28:39 EDT --- (In reply to comment #1) > For 0.4.0-1 > > * ruby(abi) dependency > - Please check > https://fedoraproject.org/wiki/Packaging/Ruby#Ruby_Packaging_Guidelines > Stupid /me, I always somehow forget this one. Fixed. > * Unused macro > - %ruby_sitelib does not to be used anywhere. > Fixed. > * Dependency > - Please check if all needed Requires are added properly. > ! For example, lib/rack/handler/mongrel.rb contains > ---------------------------------------------------------- > 1 require 'mongrel' > 2 require 'stringio' > ---------------------------------------------------------- > So this file has "Requires: rubygem(mongrel)". > However I don't know if this file itself is just optional > or not. > Anyway please check if all dependencies are correctly added. > This is entirely optional, it is one of the handlers -rack can cope with (amongst others; fastcgi and webrick) > * %gemdir/bin > - I guess files under %gemdir/bin must be moved into > %_bindir (ref: rubygem-mongrel.spec) Fixed. New SPEC: http://www.kanarip.com/custom/SPECS/rubygem-rack.spec New SRPM: http://www.kanarip.com/custom/f9/SRPMS/rubygem-rack-0.4.0-2.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review