Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=469590 --- Comment #4 from Fabian Affolter <fabian@xxxxxxxxxxxxxxxxx> 2008-11-08 16:09:22 EDT --- Thanks Dan for helping me to bring this package into Fedora. (In reply to comment #3) > - license should be MIT instead of BSD > (http://fedoraproject.org/wiki/Licensing/MIT) fixed > - $RPM_OPT_FLAGS are not used to compile, could be solved with > make %{?_smp_mflags} CFLAGS="$RPM_OPT_FLAGS -D_FILE_OFFSET_BITS=64 > -DVERSION=$(VERSION)" fixed > - rpmlint complains > cpuid.src:48: W: macro-in-%changelog doc => make it "... %%doc ..." fixed Update: Spec URL: http://fab.fedorapeople.org/packages/SRPMS/cpuid.spec SRPM URL: http://fab.fedorapeople.org/packages/SRPMS/cpuid-20060917-3.fc9.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review