[Bug 467791] Review Request: vtun - Virtual tunnel over TCP/IP networks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=467791


Lucian Langa <cooly@xxxxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |cooly@xxxxxxxxxxxx




--- Comment #1 from Lucian Langa <cooly@xxxxxxxxxxxx>  2008-11-08 12:39:13 EDT ---
rpmlint:
 W: log-files-without-logrotate /var/log/vtund

please consider adding logrotate script.


In the %files section, we prefer to use 
   %defattr(-, root, root, -)


please also consider preserving timestamps of installed files:

-p flag for install command
and INSTALL="install -p" parameter for makeinstall target.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Fedora-package-review mailing list
Fedora-package-review@xxxxxxxxxx
http://www.redhat.com/mailman/listinfo/fedora-package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]