Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=463767 --- Comment #5 from Mamoru Tasaka <mtasaka@xxxxxxxxxxxxxxxxxxx> 2008-11-08 03:15:44 EDT --- Some notes for 0.15-0.1: * SourceURL - When the source is created from git repository, please write in the spec file as comments how you created the source tarball: https://fedoraproject.org/wiki/Packaging/SourceURL#Using_Revision_Control * BuildRequires - As ppl-devel 0.10 is available on dist-f11, please modify BuildRequires. * Requires - Please check if all required packages are to be correctly installed for -devel subpackage. ! For example, %_includedir/%name/ppl_backend.h contains: -------------------------------------------------------------- 33 34 #include <ppl_c.h> 35 #include <gmp.h> 36 #include <stdlib.h> 37 #include <string.h> -------------------------------------------------------------- This means that -devel subpackage must have "Requires: ppl-devel gmp-devel" (here I am not saying about BuildRequires) * Group - Usually the main packge has "Group: System Environment/Libraries" and -devel subpackage has "Group: Development/Libraries". ! You can make your spec file based on the skeleton spec file created by $ rpmdev-newspec -t lib cloog * Dependency between main/subpackages - Usually the dependency between main package and subpackages must be EVR (Epoch:Version:Release) specific (i.e. -devel subpackage must have "Requires: %{name} = %{version}-%{release}) * Shipping static archives - Please explain why you want to ship static archives even if shared library is available. This must be avoided unless there is some specific reason. c.f. https://fedoraproject.org/wiki/Packaging/Guidelines#Exclusion_of_Static_Libraries * cflags - When compiling this software the option "-fomit-frame-pointer" is used. This option makes debugging very difficult, so this option must be removed. * Timestamps - Please consider to use -------------------------------------------------------------------- make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p" -------------------------------------------------------------------- to keep timestamps on installed files as much as possible. This method usually works for Makefiles generated by recent autotools. * %_infodir/dir file - Rebuild fails without -------------------------------------------------------------------- rm -f $RPM_BUILD_ROOT%{_infodir}/dir -------------------------------------------------------------------- http://koji.fedoraproject.org/koji/taskinfo?taskID=921939 * Info files - Files under %_infodir are automatically regarded as %doc. - Please follow https://fedoraproject.org/wiki/Packaging/ScriptletSnippets#Texinfo * %changelog format - For how to write %changelog, please follow https://fedoraproject.org/wiki/Packaging/Guidelines#Changelogs * Documents - Please add the files below to %doc of main package. -------------------------------------------------------------------- README -------------------------------------------------------------------- ! Note Please change the release number every time you modify your spec/srpm to avoid confusion. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review